refactor: build step cleanup #2926
Conversation
|
| import { glob } from "glob"; | ||
| import { World } from "../config/v2/output"; | ||
|
|
||
| export async function findSolidityFiles({ rootDir, config }: { rootDir: string; config: World }) { |
There was a problem hiding this comment.
surprised this hasn't come up before but downstream usages may need to exclude .t.sol and .s.sol
There was a problem hiding this comment.
ah likely because we're all good about putting source in src but technically possible to have test files, etc. live in this dir as well (and I personally like colocating tests with the files they're testing)
holic
force-pushed
the
holic/build-cleanup
branch
from
5fa86fb to
4880cf1
Compare
There was a problem hiding this comment.
- let's add a changeset for the changed
buildcli command - let's also quickly update this in the docs for this command (just one line): https://mud.dev/cli/tablegen
- should we also change it for the
worldgencommand for consistency?
|
this doesn't change anything about the CLI commands (they still use worldgen hasn't been updated yet, will save this for when I start updating system interfaces |
pulled out of #2923
configPathtorootDireverywhere, because we almost always want the project root dir and want to avoid usingpath.dirnamein all the downstream toolingmud buildcommandall-codegentoall-buildbecause that's actually what it's doing